Simple implementation and tests for #2191 #2220

Igmat · 2016-12-05T14:11:03Z

Summary

This PR implements #2191 issue from Jest repo itself and this one also kulshekhar/ts-jest#13.
In simple terms - it allows using Jest with TypeScript project just by adding "ts-jest": "latest" to devDependencies.

Test plan

All below configs should allow normal usage of Jest in TypeScript project.
Something like this one was used previously:

{
  "devDependencies": {
    "typescript": "latest",
    "jest": "latest",
    "ts-jest": "latest",
  },
  "jest": {
    "transform": {
      ".(ts|tsx)": "<rootDir>/node_modules/ts-jest/preprocessor.js"
    },
    "testResultsProcessor": "<rootDir>/node_modules/ts-jest/coverageprocessor.js",
    "testRegex": "(/__tests__/.*|\\.(test|spec))\\.(ts|tsx|js)$",
    "moduleFileExtensions": [
      "ts",
      "tsx",
      "js"
    ]
  }
}

With this PR config should look like this:

{
  "devDependencies": {
    "typescript": "latest",
    "jest": "latest",
    "ts-jest": "latest",
  }
}

Same behavior seems to work for babel-jest.

P.S.

It probably could also contain implementation for #2203 because it seems to be related, but I'm not sure. Could you please tell, should I implement it in this PR or make another one?

facebook-github-bot · 2016-12-05T14:11:06Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot · 2016-12-05T14:19:19Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

codecov-io · 2016-12-05T14:23:30Z

Current coverage is 89.36% (diff: 100%)

Merging #2220 into master will not change coverage

@@             master      #2220   diff @@
==========================================
  Files            39         39          
  Lines          1467       1467          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1311       1311          
  Misses          156        156          
  Partials          0          0

Powered by Codecov. Last update c3324a8...97bdaed

Igmat · 2016-12-05T14:37:41Z

I probably have to create integration tests or you may want me to make some changes in ts-jest. If so, please, feel free to tell it here or create issue in ts-jest repo if it's more related to it than to this integration PR.

Igmat · 2016-12-07T15:10:29Z

@cpojer could you, please, provide some feedback on this?

cpojer · 2016-12-07T15:14:37Z

Hello! I will take a look when I have time. I work on Jest in open source mostly on my own time and I haven't had much time recently.

Igmat · 2016-12-07T16:13:45Z

@cpojer, excuse me for hurrying you, I don't want to do that.

Igmat · 2016-12-12T15:39:16Z

Should I resolve those new conflicts?

cpojer · 2016-12-12T15:47:26Z

Hey, I was just finally able to take a look at this.

I'm not sure if we want to make ts-jest a default in Jest like this. First, I just refactored this test which was super annoying to work with, so any simplification you can make there is appreciated. Second, ts-jest is not really official but I'd like to figure out a way to make it work well with Jest without hardcoding so much. Do you have any suggestions to implement this better?

Igmat · 2016-12-12T16:10:52Z

Ok, I have several ideas:

I could try to move logic needed for ts-jest into separate file and call it from normalize.js, so code will be less noisy.
I could move such logic into ts-jest itself, and leave only call for it from normalize.js, so this config always will be up to date for TypeScript projects.
We could add something like externalConfig option to Jest config which will use provided path as default values, so anybody who wants to use ts-jest plugin will have to include only one option instead of 4-5 as it is now.

cpojer · 2016-12-12T16:12:47Z

We do have a "preset" option – it only sucks if you want to use more than one, like TypeScript together with react-native. How about in addition we add a "presets" option that can take N number of presets? They may conflict, so it may not be a good idea.

Igmat · 2016-12-12T16:29:04Z

Thanks for pointing to preset option, I somehow missed it.
It could be a good idea, but it seems to me that there would be a lot of issues. Mostly with "setupFiles".
Currently ts-jest doesn't provide any, but it could (e.g. to resolve this kulshekhar/ts-jest#79), also their order becomes very important.
After all current implementation will override important part of preset from ts-jest if it finds babel-jest due to this.

cpojer · 2017-01-07T12:41:23Z

setupFiles from presets get merged with the local config, so that should work just fine.

cpojer · 2017-01-08T22:29:24Z

@Igmat thank you for the PR and for the discussion here. Let's go back to the issue and take what we learned from this to make this a bit better. I do definitely want better ts-jest integration but I don't think this is the right way. I think we should try the preset way: let's expand the feature (see normalize.js) to support ts-jest well so we can make it easier to use. I think it is ok if it isn't automatic as long as it is simple to setup.

github-actions · 2021-05-14T03:14:42Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Igmat added 2 commits December 5, 2016 14:37

Simple implementation and tests for jestjs#2191

63fa8c2

Changing default testRegex is ts-jest is enabled.

97bdaed

facebook-github-bot added the CLA Signed ✔️ label Dec 5, 2016

cpojer closed this Jan 8, 2017

github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simple implementation and tests for #2191 #2220

Simple implementation and tests for #2191 #2220

Igmat commented Dec 5, 2016

facebook-github-bot commented Dec 5, 2016

facebook-github-bot commented Dec 5, 2016

codecov-io commented Dec 5, 2016 •

edited

Loading

Igmat commented Dec 5, 2016

Igmat commented Dec 7, 2016

cpojer commented Dec 7, 2016

Igmat commented Dec 7, 2016 •

edited

Loading

Igmat commented Dec 12, 2016

cpojer commented Dec 12, 2016

Igmat commented Dec 12, 2016

cpojer commented Dec 12, 2016

Igmat commented Dec 12, 2016

cpojer commented Jan 7, 2017

cpojer commented Jan 8, 2017

github-actions bot commented May 14, 2021

Simple implementation and tests for #2191 #2220

Simple implementation and tests for #2191 #2220

Conversation

Igmat commented Dec 5, 2016

Summary

Test plan

P.S.

facebook-github-bot commented Dec 5, 2016

facebook-github-bot commented Dec 5, 2016

codecov-io commented Dec 5, 2016 • edited Loading

Current coverage is 89.36% (diff: 100%)

Igmat commented Dec 5, 2016

Igmat commented Dec 7, 2016

cpojer commented Dec 7, 2016

Igmat commented Dec 7, 2016 • edited Loading

Igmat commented Dec 12, 2016

cpojer commented Dec 12, 2016

Igmat commented Dec 12, 2016

cpojer commented Dec 12, 2016

Igmat commented Dec 12, 2016

cpojer commented Jan 7, 2017

cpojer commented Jan 8, 2017

github-actions bot commented May 14, 2021

codecov-io commented Dec 5, 2016 •

edited

Loading

Igmat commented Dec 7, 2016 •

edited

Loading